This forum has moved to forum.jeelabs.net - this read-only archive is for reference only!
Hi,
I just noticed the following:
class MilliTimer {
word next;
[...]
void MilliTimer::set(word ms) {
[...]
next = millis() + ms - 1;
wiring.h: typedef unsigned int word;
-> millis() returns a (unsigned) 32-bit word and MilliTimer assigns it to a (signed) 16-bit word.
This will probably fail on a 15-bit overflow.
I guess a quickfix is to use an unsigned long in MilliTimer.
Cheers,
-Marius
This is intentional. The MilliTimer is for values up to (and including) 60,000 only, i.e. a mere 60 seconds max.
I want to create another timer class for seconds, again probably using a word, i.e. only up to a few hours.
Reason is a (possibly misguided) attempt to maximize performance and keep RAM usage low. The overflow, as I understand it, will truncate the long to a short, and make it a 16-bit counter which wraps around. Due to the way I'm using this unsigned 16-bit value, wrap-around should not cause problems (unless I made a mistake somewhere). It's fairly tricky, because with overflow, "a < b-c" is not the same as "a+c < b", for example.