Problems with page links on this forum

(7 posts) (2 voices)

Tags:

No tags yet.

tankslappa

Is it just me (on two different machines and two different browsers - Firefox and Chrome), or are the page links on the bottom of the forum a bit insane? All looks, and works fine on the front page, but if you go to page 2 the link for "previous" and "Page 1" both go to http://talk.jeelabs.net/page/2
If you go to page 3, the "Page 2" icon and "previous" both link to http://talk.jeelabs.net/page/2 (hurrah) Unfortunately the "Page 1" links to http://talk.jeelabs.net/page/3 :-/
Basically naughty "Page 1" always tries to link to the current page. "previous" works on all pages except the second page, where it wants to link to the second page and not the first.
Really rather odd!

Posted 31/05/2010 04:08:51
jcw

Yeah - I suspect that it has to do with the rewriting rules needed to make this work. They were written for apache, but I use lighttpd - probably something got lost in translation... basically, the link to page 1 never works.
Hm, wait... looks like the reference to page 1 is done as: href="" - should probably be "href=".". I know little about bbPress internals, was hoping that a new release would fix it, but the bbPress software has stagnated, it seems :(

Posted 31/05/2010 09:44:16
jcw

Ok, I hacked my way into bbPress - I think all the cases work now... can you check?

Posted 31/05/2010 11:05:51
jcw
For the record, what I did was to insert the following line:
```
    $emptyformat = strreplace( '/page/%%', $format, '/');
```
... before this one in bb-includes/functions.bb-core.php, line 249:
```
    if ( $prevnext && $current && 1 < $current ) {
```
Posted 31/05/2010 11:09:08


	
		
			
								
					tankslappa

				
			
			
				
Looks good to me :)
Nice one JC



				Posted 31/05/2010 17:33:46
			
		
	
	
		
			
								
					tankslappa

				
			
			
				
Pssst, Found another one!
On threads with more than one page, like the Jeecar one, go to page 2, then try to navigate back to page 1... There seems to be a slash on the end it doesn't like.



				Posted 02/06/2010 13:28:06
			
		
	
	
		
			
								
					jcw

				
			
			
				
Thx. It's a result of my earlier hack (slashes at the end are quite inconsistent in bbPress, it seems). I've "loosened" a URL rewrite rule.



				Posted 02/06/2010 14:09:22