Why does it always send data 7 Times.

(5 posts) (2 voices)

Tags:

No tags yet.

kami

Hi,

i am trying to send a data package to a server with this Code:

    #include 
    #include 
    #include

    // Plug on P1 for testing the button and the LED.
    Port connector(1);
    // Variables for the 5 different counters
    int intcount,sendingsdone = 0;
    int counters[5];
    byte status = 0;
    byte radioIsOn;
    // counter for sending every 15 seconds
    MilliTimer countTimer;

    typedef struct {
        unsigned int device;
        unsigned int count1;
            unsigned int count2;
        unsigned int count3;
            unsigned int count4;
        unsigned int count5;
    } counterdata;

    static void lowPower (byte mode) {
     // disable the ADC
    byte prrSave = PRR, adcsraSave = ADCSRA;
    ADCSRA &= ~ bit(ADEN);
    PRR &= ~ bit(PRADC);
    // go into power down mode
    setsleepmode(mode);
    sleepmode();
    // re-enable the ADC
    PRR = prrSave;
    ADCSRA = adcsraSave;
    }

     void setup () {
        connector.mode(OUTPUT);
        connector.digiWrite(1);  
        connector.mode2(INPUT); // Set AIO mode as input
        connector.digiWrite2(1); // Activate pull-up resistor for

        // Serial for testing and Rf12 for sending

        Serial.begin(57600);
        rf12config();
        rf12easyInit(0);

        for (int i=0;i<5;i++) {
         counters[i] = 0;
        }

        lowPower(SLEEPMODEIDLE);
        radioIsOn = 1;

     void loop () {
        // This button block is for counting the button press
        // At the first 10 sendings the LED should show if the button was pressed.
        // After 10 sendings the LED should be off
         byte pushed = connector.digiRead2();

        if (radioIsOn && rf12easyPoll() == 0) {
            rf12sleep(0); // turn the radio off
            radioIsOn = 0;
            Serial.print("off");
        }
      if (pushed == 0 && status == 0){
            status =1;}
    if (pushed == 1 && status == 1){ 
            status =0;
            counters[intcount] +=1;

        if (sendingsdone<=10) {     
            connector.digiWrite(0);
            delay(100);
            connector.digiWrite(1);
        }
    }
    // In this block the same output on the Serial console should be send over RF12.
    // The Output on the recieving PC (RF12 Jeelink) should be look like this  "Logger1=0=0=0=0=0"
    // All 15 seconds (intcoundcountTimer (35)) the new data should be send.
   if ( intcount==5) {
            sendingsdone+=1;
            counterdata sendcount;
                sendcount.device = 192;
            sendcount.count1 = counters[0];
            sendcount.count2 = counters[1];
            sendcount.count3 = counters[2];
            sendcount.count4 = counters[3];
            sendcount.count5 = counters[4];

            char sending = rf12easySend(&sendcount, sizeof sendcount);
                if (sending) {
            // make sure the radio is on again
                if (!radioIsOn)
              rf12sleep(-1); // turn the radio back on
                  radioIsOn = 1;
                  Serial.print("on");

            Serial.print("Logger1");

            for (int i=0;i<5;i++){
             Serial.print("=");
                Serial.print(countersi;
            }
            Serial.print("\n");

        for (int i=0;i<5;i++) {
            counters[i] = 0;
        }
        intcount=0;
    }

    // The timer for changing the counter variables
        if (countTimer.poll(3000)) {
            intcount+=1;
        }

I hope someone can tell me why i get this Output after pressing the button 2 times:

Logger=192=0=0=0=0=2 Logger=192=0=0=0=0=2 Logger=192=0=0=0=0=2 Logger=192=0=0=0=0=2 Logger=192=0=0=0=0=2 Logger=192=0=0=0=0=2 Logger=192=0=0=0=0=2

I don't understand why the Server gets the data more than one time?

thanks a lot.

Cu kami

Posted 09/10/2010 11:44:03

kami

Hi no One here how can help me please Tell me how to send Data correctly. Thank you Cu kami

Posted 09/10/2010 22:27:52
jcw

Sorry for not responding sooner - it's a bit more code than I can easily skim through...
The sketch will send out the data a few times if you use rf12easySend(), because it expects an ACK reply from the receiver. Make sure you have a receiver setup to do this, for example a JeeNode or JeeLink running RF12demo in the proper frequency band and net group (and with "collect mode" off, as it it is by default, i.e. "0c").

Posted 09/10/2010 23:02:10

kami

Hi,

thanks a lot for the Answer. I just missed to add the ACK reply on the server now it works fine. The Server sketch looks like this now:

    #include 
    #include

    void setup() {

    Serial.begin(57600);
    Serial.print("\nGetloggerdata;
    rf12config();
    }

    void loop() {

    if (rf12recvDone() && rf12crc == 0 ) {

            
       byte n = rf12len;
    Serial.print("Logger");

    for (byte i = 0; i < n; ++i) {
      if (i%2 ==0) {
        Serial.print('=');
        Serial.print((int) rf12datai;}
    }

    Serial.println();
       if ((rf12hdr & RF12HDRACK) && !(rf12hdr & RF12HDRCTL))
                    {
                
                byte addr = rf12hdr & RF12HDRMASK;
                // if request was sent only to us, send ack back as broadcast
                rf12sendStart(rf12hdr & RF12HDRDST ? RF12HDRCTL :
                                    RF12HDRCTL | RF12HDRDST | addr, 0, 0);
            }
    }
    }

Is this okay?

But now there is a second question:

If i send now data it only turns on the radio if there is a new data package. If the counter values doesnt change the sender will not turn on. This is okay the power consumption will be less. But why does it work like this? How can i change it?

And another question did i need a rf12easyPoll(); before the :

char sending = rf12easySend(&sendcount, sizeof sendcount);

Thank you.

Cu kami

Posted 10/10/2010 10:51:36

jcw

Great to hear that it works now.
> If i send now data it only turns on the radio if there is a new data package.
That's by design in rf12easySend(). If you don't want that, use rf12sendStart() (which does not re-transmit or ack management).
> did i need a rf12easyPoll(); before the
Ah, wait. Replace `if (rf12recvDone() && rf12crc == 0 ) {` by `if (rf12easyPoll() > 0 ) {` - don't mix the two approaches.

Posted 10/10/2010 11:23:33